fix: raise RefreshError for missing token in impersonated credentials #1897
Conversation
Instead of crashing with a KeyError when the ID token is missing from the response (even if the status code is 200), raise a proper RefreshError. Fixes #1167
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Instead of crashing with a KeyError when the ID token is missing from the response (even if the status code is 200), raise a proper RefreshError. Fixes #1167
chalmerlowe
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 <details><summary>google-auth: 2.46.0</summary> ## [2.46.0](v2.45.0...v2.46.0) (2026-01-05) ### Features * Recognize workload certificate config in has_default_client_cert_source for mTLS for Agentic Identities (#1907) ([0b9107d](0b9107d5)) ### Bug Fixes * Fix test coverage for mtls_helper (#1886) ([02e7163](02e71631)) * use .read() instead of .content.read() in aiohttp transport (#1899) ([12f4470](12f4470f)) * add types to default and verify_token and Request __init__ based on comments in the source code. (#1588) ([59a5f58](59a5f588)) * fix the document of secure_authorized_session (#1536) ([5d00147](5d001470)) * raise RefreshError for missing token in impersonated credentials (#1897) ([94d04e0](94d04e09)) * remove setup.cfg configuration for creating universal wheels (#1693) ([c767531](c767531c)) ### Documentation * update urllib3 docstrings for v2 compatibility (#1903) ([3f1aeea](3f1aeea2)) </details>
3 participants
Previously,
IDTokenCredentials.refreshwould raise aKeyErrorif the response from the IAM server was200 OKbut did not contain the expected "token" field. This change wraps the token extraction in atry...exceptblock to catchKeyError(andValueErrorfor malformed JSON) and raises agoogle.auth.exceptions.RefreshErrorinstead, which is the expected behavior for credential refresh failures.I've added a new test
tests/test_impersonated_credentials.pyto verify:200 OKresponse with a missing token now raisesRefreshError.RefreshErroras before.This PR replaces the PR #1167 from 3 years ago that addressed this issue, but was less robust/not fully correct.
PR created automatically by Jules for task 3520893520890582850 started by @chalmerlowe