fix: updated the lower bound of interactive timeout and fix the kwarg… #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BigTailWolf
commented
Nov 9, 2022
BigTailWolf
commented
- Udpated the lower bound of interactive timeout
- Fix the kwargs invalid syntax
BigTailWolf
requested review from
a team,
arithmetic1728 and
sai-sunder-s
as code owners
BigTailWolf
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
clundin25
changed the title
clundin25
approved these changes
Nov 9, 2022
clundin25
reviewed
Nov 9, 2022
yoshi-kokoro
removed
the
kokoro:force-run
clundin25
suggested changes
Nov 9, 2022
Contributor
clundin25
left a comment
clundin25
left a comment
There was a problem hiding this comment.
This change needs accompanied unit tests
clundin25
reviewed
Nov 9, 2022
google/auth/pluggable.py
Outdated
| "output_file" | ||
| ) | ||
| self._tokeninfo_username = kwargs.get("tokeninfo_username", "") # dummy value | ||
| self._tokeninfo_username = "" # dummy value. This variable is only used via injection, not exposed to ctor |
Contributor
There was a problem hiding this comment.
Nit: I think None is a more appropriate placeholder
Contributor
Author
There was a problem hiding this comment.
Then we are going to re-write a bunch of tests since we didn't properly mock the behavior.
This will be updated by a full feature of retrieve token info from the proper endpoint.
clundin25
approved these changes
Nov 9, 2022
lsirac
reviewed
Nov 9, 2022
BigTailWolf
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
lsirac
added
the
do not merge
lsirac
removed
the
do not merge
lsirac
approved these changes
Nov 10, 2022
BigTailWolf
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.