Skip to content

Conversation

@GeyseR
Copy link
Contributor

@GeyseR GeyseR commented Apr 27, 2022

At the time of the update the threshold has been changed from 10 to 20 seconds at some point.
I believe it is better to use more general wording and let explore REFRESH_THRESHOLD for the exact value

@GeyseR GeyseR requested review from a team, arithmetic1728 and sai-sunder-s as code owners April 27, 2022 08:02
@google-cla
Copy link

google-cla bot commented Apr 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 28, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 28, 2022
@arithmetic1728 arithmetic1728 changed the title Update comment about token expiration threshold chore: Update comment about token expiration threshold Apr 28, 2022
@arithmetic1728 arithmetic1728 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2022
@arithmetic1728 arithmetic1728 merged commit 74860e5 into googleapis:main Apr 28, 2022
@GeyseR GeyseR deleted the patch-1 branch April 29, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants