Skip to content

Add support for InsecureCredentials - #208

Merged
dwsupplee merged 1 commit into
googleapis:masterfrom
michaelbausor:add-insecure-credentials
Sep 12, 2018
Merged

dwsupplee merged 1 commit into
googleapis:masterfrom
michaelbausor:add-insecure-credentials

Conversation

@michaelbausor

Copy link
Copy Markdown
Contributor

Adds support for insecure credentials, which can be used when calling APIs that don't require credentials (e.g. public buckets), emulators, or test services.

cc @tmatsuo @bshaffer @dwsupplee @jdpedrie

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2018
@michaelbausor

Copy link
Copy Markdown
Contributor Author

@dwsupplee I don't have merge access - if you do, can you merge? Otherwise, tagging @bshaffer and @tmatsuo

@dwsupplee
dwsupplee merged commit 9d6b509 into googleapis:master Sep 12, 2018
@dwsupplee

Copy link
Copy Markdown
Contributor

Done!

@michaelbausor
michaelbausor deleted the add-insecure-credentials branch September 13, 2018 17:08
@bshaffer

Copy link
Copy Markdown
Contributor

Definitely too late to change anything now, but why wasn't this called EmptyCredentials?

@michaelbausor

Copy link
Copy Markdown
Contributor Author

I think EmptyCredentials or AnonymousCredentials would have been fine too - do you think that would have been preferable to InsecureCredentials?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants