This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: Removing 3pi config URL validation#1517
Merged
aeitzman merged 4 commits intogoogleapis:mainfrom Feb 3, 2023
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
aeitzman
changed the title
aeitzman
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
aeitzman
added
kokoro:run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
kokoro:run
|
Warning: This pull request is touching the following templated files:
|
aeitzman
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
BigTailWolf
approved these changes
Feb 2, 2023
lsirac
approved these changes
Feb 3, 2023
BigTailWolf
approved these changes
Feb 3, 2023
danielbankhead
approved these changes
Feb 3, 2023
Contributor
danielbankhead
left a comment
danielbankhead
left a comment
There was a problem hiding this comment.
Ah, this PR looks refreshing 😌 LGTM
gopherbot
pushed a commit
to golang/oauth2
that referenced
this pull request
Feb 17, 2023
…Ls in ADC files Removes URL validation for token_url, service_account_impersonation_url to allow for TPC urls and adds line to the docs to warn users. See googleapis/google-auth-library-nodejs#1517 for same change in node.js library. Change-Id: I85fa67ee0b99deed2adb75668a1b5501851c499c GitHub-Last-Rev: 15d7759 GitHub-Pull-Request: #627 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/465696 Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Leo Siracusa <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing url validation so we can support TPC urls.
Added documentation in readme warning users to check URL's for any configuration obtained by a third party.