This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: expose missing external account client types/classes#1142
Merged
bcoe merged 1 commit intogoogleapis:masterfrom Feb 10, 2021
bojeil-google:master
Merged
fix: expose missing external account client types/classes#1142bcoe merged 1 commit intogoogleapis:masterfrom bojeil-google:master
bcoe merged 1 commit intogoogleapis:masterfrom
bojeil-google:master
Conversation
…tOptions` The above base class and interface need to be exposed to unblock downstream libraries dependency on v7. googleapis/nodejs-googleapis-common#363 googleapis/google-api-nodejs-client#2514 googleapis/nodejs-translate#622 googleapis/gax-nodejs#959
google-cla
Bot
added
the
cla: yes
Contributor
Author
|
@bcoe more changes are needed in the broken client libraries but we can't resolve those issues without first exposing these types/classes. |
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
=======================================
Coverage 93.74% 93.75%
=======================================
Files 28 28
Lines 6253 6257 +4
Branches 654 655 +1
=======================================
+ Hits 5862 5866 +4
Misses 391 391
Continue to review full report at Codecov.
|
bcoe
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
BaseExternalAccountClientandBaseExternalAccountClientOptionsThe above base class and interface need to be exposed to unblock downstream libraries dependency on v7.
googleapis/nodejs-googleapis-common#363
googleapis/google-api-nodejs-client#2514
googleapis/nodejs-translate#622
googleapis/gax-nodejs#959