chore: Add googleapis-auth as codeowner team#950
Conversation
|
Warning: This pull request is touching the following templated files:
|
| * @googleapis/yoshi-java | ||
| # The @googleapis/googleapis-auth is the default owner for changes in this repo | ||
| * @googleapis/yoshi-java @googleapis/googleapis-auth | ||
| **/*.java @googleapis/googleapis-auth |
There was a problem hiding this comment.
dumb q- what does line 9 do? Seems like line 8 is giving @googleapis/googleapis-auth edit access to all the files in the repo already, so is line 9 redundant?
There was a problem hiding this comment.
I believe from the docs (https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file), the last matching pattern takes precedence. For any non *.java files, yoshi-java and googleapis-auth should be able to approve, but only googleapis-auth is allowed to approve for *.java (and samples.java has their own rule)
These changes are from owlbot (and I believe from the template in the synthtool).
There was a problem hiding this comment.
OwlBot doesn't control this repository's Java code.
alicejli
left a comment
alicejli
left a comment
There was a problem hiding this comment.
quick question in comments - otherwise, looks good.
suztomo
left a comment
suztomo
left a comment
There was a problem hiding this comment.
I went ahead with granting the Write role to the new team. This removed the warning message.
|
BTW, please use |
meltsufin
changed the title
5 participants
BEGIN_COMMIT_OVERRIDE
chore: Add googleapis-auth as codeowner team
END_COMMIT_OVERRIDE