fix: add validation for the token URL and service account impersonation URL for Workload Identity Federation#717
Merged
lsirac merged 4 commits intogoogleapis:masterfrom Aug 17, 2021
lsirac:validate
Merged
fix: add validation for the token URL and service account impersonation URL for Workload Identity Federation#717lsirac merged 4 commits intogoogleapis:masterfrom lsirac:validate
lsirac merged 4 commits intogoogleapis:masterfrom
lsirac:validate
Conversation
…on URL in ExternalAccountCredentials
google-cla
bot
added
the
cla: yes
TimurSadykov
approved these changes
Aug 11, 2021
TimurSadykov
left a comment
TimurSadykov
left a comment
There was a problem hiding this comment.
LGTM, some minor suggestions on test cases
oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountCredentialsTest.java
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountCredentialsTest.java
Show resolved
Hide resolved
lesv
approved these changes
Aug 17, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/google-auth-library-java/compare/v1.0.0...v1.1.0) (2021-08-17) ### Features * downscoping with credential access boundaries ([#702](https://www.github.com/googleapis/google-auth-library-java/issues/702)) ([aa7ede1](https://www.github.com/googleapis/google-auth-library-java/commit/aa7ede1d1c688ba437798f4204820c0506d5d969)) ### Bug Fixes * add validation for the token URL and service account impersonation URL for Workload Identity Federation ([#717](https://www.github.com/googleapis/google-auth-library-java/issues/717)) ([23cb8ef](https://www.github.com/googleapis/google-auth-library-java/commit/23cb8ef778d012bbd452c1dfdac5f096d1af6c95)) ### Documentation * updates README for downscoping with CAB ([#716](https://www.github.com/googleapis/google-auth-library-java/issues/716)) ([68bceba](https://www.github.com/googleapis/google-auth-library-java/commit/68bceba21c05870f6eb616cc057ddf0521c581b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches the token URLs host to:
Matches the service account impersonation URLs host to:
Scheme must be HTTPS.