feat: add logging at FINE level for each step of ADC#435
Merged
chingor13 merged 3 commits intogoogleapis:masterfrom Aug 4, 2020
Merged
feat: add logging at FINE level for each step of ADC#435chingor13 merged 3 commits intogoogleapis:masterfrom
chingor13 merged 3 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
============================================
+ Coverage 79.50% 79.61% +0.11%
Complexity 397 397
============================================
Files 27 27
Lines 1800 1810 +10
Branches 186 188 +2
============================================
+ Hits 1431 1441 +10
Misses 269 269
Partials 100 100
Continue to review full report at Codecov.
|
elharo
approved these changes
Aug 4, 2020
BenWhitehead
approved these changes
Aug 4, 2020
oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #430
Also changing the INFO message that we couldn't detect compute engine credentials as that's a perfectly normal case and can be checked by the return value.