Skip to content

Fix#228 update default metadata url#230

Merged
sduskis merged 1 commit intogoogleapis:masterfrom
ajaaym:fix_228
Mar 25, 2019
Merged

Fix#228 update default metadata url#230
sduskis merged 1 commit intogoogleapis:masterfrom
ajaaym:fix_228

Conversation

@ajaaym
Copy link
Copy Markdown
Contributor

@ajaaym ajaaym commented Mar 8, 2019

Fixes #228

@ajaaym ajaaym requested a review from a team March 8, 2019 15:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@44a5d33). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #230   +/-   ##
=========================================
  Coverage          ?   78.26%           
  Complexity        ?      329           
=========================================
  Files             ?       21           
  Lines             ?     1445           
  Branches          ?      158           
=========================================
  Hits              ?     1131           
  Misses            ?      236           
  Partials          ?       78
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 86.23% <ø> (ø) 31 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a5d33...ad6746d. Read the comment docs.

sduskis
sduskis reviewed Mar 8, 2019
View reviewed changes
Comment thread oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java

// Note: the explicit IP address is used to avoid name server resolution issues.
static final String DEFAULT_METADATA_SERVER_URL = "http://169.254.169.254";
static final String DEFAULT_METADATA_SERVER_URL = "http://metadata.google.internal";
Copy link
Copy Markdown
Contributor

@sduskis sduskis Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use metadata.google.internal. with the . at the end. We need that to solve a nasty problem in docker related to that problem.

Copy link
Copy Markdown
Contributor Author

@ajaaym ajaaym Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this issue #4269 and its fixed with http://metadata.google.internal for GKE and GCE both.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 15, 2019
@sduskis sduskis merged commit 4c8360e into googleapis:master Mar 25, 2019
@JesseLovelace JesseLovelace mentioned this pull request Mar 25, 2019
Merged
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DefaultCredentialsProvider is broken for java8 app engine

4 participants

@ajaaym @sduskis @googlebot @yoshi-automation