Overload GoogleCredentials.createScoped with variadic arguments#218
Merged
chingor13 merged 2 commits intogoogleapis:masterfrom Dec 28, 2018
chingor13:overload-create-scoped
Merged
Overload GoogleCredentials.createScoped with variadic arguments#218chingor13 merged 2 commits intogoogleapis:masterfrom chingor13:overload-create-scoped
chingor13 merged 2 commits intogoogleapis:masterfrom
chingor13:overload-create-scoped
Conversation
googlebot
added
the
cla: yes
JesseLovelace
approved these changes
Dec 28, 2018
| * @return GoogleCredentials with requested scopes. | ||
| */ | ||
| public GoogleCredentials createScoped(String... scopes) { | ||
| return createScoped(scopes); |
Contributor
There was a problem hiding this comment.
Looks like this will just call itself, eventually resulting in a stack overflow.
Perhaps this should be:
return createScoped(ImmutableList.copyOf(scopes));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5