doc: Samples for Documenting Custom Credential Suppliers#1820
Merged
vverman merged 8 commits intogoogleapis:mainfrom Oct 28, 2025
Merged
doc: Samples for Documenting Custom Credential Suppliers#1820vverman merged 8 commits intogoogleapis:mainfrom
vverman merged 8 commits intogoogleapis:mainfrom
Conversation
…Workloads and Okta Workload.
vverman
force-pushed
the
chore/document-custom-credential-suppliers
branch
from
d6f790b to
49d17f5
Compare
lqiu96
reviewed
Oct 13, 2025
lqiu96
reviewed
Oct 13, 2025
lqiu96
reviewed
Oct 13, 2025
lqiu96
previously approved these changes
Oct 13, 2025
lsirac
previously approved these changes
Oct 20, 2025
lqiu96
reviewed
Oct 22, 2025
lqiu96
reviewed
Oct 22, 2025
lqiu96
reviewed
Oct 22, 2025
lqiu96
reviewed
Oct 22, 2025
lqiu96
reviewed
Oct 22, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 23, 2025
lqiu96
reviewed
Oct 24, 2025
| // Check if the current token is still valid (with a 60-second buffer). | ||
| boolean isTokenValid = | ||
| this.accessToken != null | ||
| && Instant.now().isBefore(this.expiryTime.minusSeconds(TOKEN_REFRESH_BUFFER_SECONDS)); |
Member
There was a problem hiding this comment.
nit: I think it would be slightly clearer if you reverse the logic. Feel free to ignore this if you disagree
// Current time + buffer < expirationTime = does not need a refresh
Instant.now().plusSecond(TOKEN_REFRESH_BUFFER_SECONDS).isBefore(this.expiryTime)
bourgeoisor
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documenting the custom credential supplier for authenticating:
AWS Workloads.
Okta Workloads.