Skip to content

chore: Resolve flaky test PluggableAuthHandlerTest.getExecutableResponse_samlResponse#1818

Merged
lqiu96 merged 1 commit intomainfrom
fix_flaky_PluggableAuthHandlerTest
Oct 13, 2025
Merged

chore: Resolve flaky test PluggableAuthHandlerTest.getExecutableResponse_samlResponse#1818
lqiu96 merged 1 commit intomainfrom
fix_flaky_PluggableAuthHandlerTest

Conversation

@lqiu96
Copy link
Copy Markdown
Member

@lqiu96 lqiu96 commented Oct 10, 2025

Fixes: #1817

@lqiu96 lqiu96 requested review from a team October 10, 2025 19:20
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Oct 10, 2025
lqiu96
lqiu96 commented Oct 10, 2025
View reviewed changes
Comment thread oauth2_http/javatests/com/google/auth/oauth2/PluggableAuthHandlerTest.java
Comment on lines +747 to +749
assertTrue(
Instant.now().getEpochSecond()
< Instant.ofEpochSecond(response.getExpirationTime()).getEpochSecond());
Copy link
Copy Markdown
Member Author

@lqiu96 lqiu96 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opt to check for a future time instead of non-null is due to this test (checks for an invalid time):

google-auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/PluggableAuthHandlerTest.java

Line 611 in 98b62ba

public void retrieveTokenFromExecutable_expiredResponse_throws()

I think the test would be more accurate asserting for a valid response

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2025
@lqiu96
Copy link
Copy Markdown
Member Author

lqiu96 commented Oct 10, 2025 

[FATAL] Non-resolvable parent POM for com.google.auth:google-auth-library-parent:1.39.2-SNAPSHOT: The following artifacts could not be resolved: com.google.cloud:google-cloud-shared-config:pom:1.16.1 (absent): Could not transfer artifact com.google.cloud:google-cloud-shared-config:pom:1.16.1 from/to central (https://repo.maven.apache.org/maven2): Network is unreachable and 'parent.relativePath' points at wrong local POM @ line 16, column 11

@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2025
@lqiu96 lqiu96 requested a review from zhumin8 October 10, 2025 19:59
zhumin8
zhumin8 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lqiu96 lqiu96 merged commit 3149c90 into main Oct 13, 2025
29 checks passed
@lqiu96 lqiu96 deleted the fix_flaky_PluggableAuthHandlerTest branch October 13, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhumin8 zhumin8 zhumin8 approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky Test: PluggableAuthHandlerTest.getExecutableResponse_samlResponse

3 participants

@lqiu96 @zhumin8 @yoshi-kokoro