Add windows Kokoro test config#181
Merged
chingor13 merged 10 commits intogoogleapis:masterfrom Sep 11, 2018
chingor13:kokoro-windows
Merged
Add windows Kokoro test config#181chingor13 merged 10 commits intogoogleapis:masterfrom chingor13:kokoro-windows
chingor13 merged 10 commits intogoogleapis:masterfrom
chingor13:kokoro-windows
Conversation
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
Author
|
The windows build isn't showing up yet, so this isn't quite ready. |
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
elharo
reviewed
Sep 10, 2018
| TestDefaultCredentialsProvider testProvider = new TestDefaultCredentialsProvider(); | ||
| String userPath = "/user.json"; | ||
| File credentialFile = File.createTempFile("user", ".json"); | ||
| credentialFile.deleteOnExit(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| TestDefaultCredentialsProvider testProvider = new TestDefaultCredentialsProvider(); | ||
| String serviceAccountPath = "/service_account.json"; | ||
| File serviceAccountFile = File.createTempFile("service_account", ".json"); | ||
| serviceAccountFile.deleteOnExit(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| UserCredentialsTest.writeUserStream(USER_CLIENT_ID, USER_CLIENT_SECRET, refreshTokenEnv); | ||
| String envPath = "/env.json"; | ||
| File envFile = File.createTempFile("env", ".json"); | ||
| envFile.deleteOnExit(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The actual file is not necessary for the tests - we only need a valid path for the OS.
jeanbza
approved these changes
Sep 10, 2018
elharo
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/in file path)