Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Jan 16, 2025

Fixes #1545

Config structure borrowed from https://github.com/googleapis/sdk-platform-java + docs on bootstrapping config

Proof generated PR (updates readmes mentioned in parent issue). PR manually generated via release-please release-pr --token 🚀 --repo-url=https://github.com/googleapis/google-auth-library-java --target-branch setup-release-please

Proof that the config is valid (same command in parent issue used to fail):

diegomarquezp@diegomarquezp1:~/google/google-auth-library-java$ release-please debug-config --debug --repo-url=https://github.com/googleapis/google-auth-library-java --dry-run --target-branch setup-release-please
> Fetching release-please-config.json from branch setup-release-please
> Fetching .release-please-manifest.json from branch setup-release-please
Manifest {
  repository: {
    owner: 'googleapis',
    repo: 'google-auth-library-java',
    defaultBranch: 'main'
  },
  github: GitHub {
    getCommitFiles: [AsyncFunction (anonymous)],
    graphqlRequest: [AsyncFunction (anonymous)],
    findFilesByFilenameAndRef: [AsyncFunction (anonymous)],
    findFilesByGlobAndRef: [AsyncFunction (anonymous)],
    createPullRequest: [AsyncFunction (anonymous)],
    getPullRequest: [AsyncFunction (anonymous)],
    updatePullRequest: [AsyncFunction (anonymous)],
    findFilesByExtensionAndRef: [AsyncFunction (anonymous)],
    createRelease: [AsyncFunction (anonymous)],
    commentOnIssue: [AsyncFunction (anonymous)],
    removeIssueLabels: [AsyncFunction (anonymous)],
    addIssueLabels: [AsyncFunction (anonymous)],
    repository: {
      owner: 'googleapis',
      repo: 'google-auth-library-java',
      defaultBranch: 'main'
    },
    octokit: OctokitWithDefaults {
      request: [Function],
      graphql: [Function],
      log: [Object],
      hook: [Function],
      auth: [AsyncFunction (anonymous)],
      actions: [Object],
      activity: [Object],
      apps: [Object],
      billing: [Object],
      checks: [Object],
      codeScanning: [Object],
      codesOfConduct: [Object],
      codespaces: [Object],
      dependabot: [Object],
      dependencyGraph: [Object],
      emojis: [Object],
      gists: [Object],
      git: [Object],
      gitignore: [Object],
      interactions: [Object],
      issues: [Object],
      licenses: [Object],
      markdown: [Object],
      meta: [Object],
      migrations: [Object],
      orgs: [Object],
      packages: [Object],
      projects: [Object],
      pulls: [Object],
      rateLimit: [Object],
      reactions: [Object],
      repos: [Object],
      search: [Object],
      secretScanning: [Object],
      securityAdvisories: [Object],
      teams: [Object],
      users: [Object],
      rest: [Object],
      paginate: [Function]
    },
    request: [Function: newApi] {
      endpoint: [Function],
      defaults: [Function: bound withDefaults]
    },
    graphql: [Function: newApi] {
      defaults: [Function: bound withDefaults],
      endpoint: [Function]
    },
    fileCache: RepositoryFileCache {
      octokit: [OctokitWithDefaults],
      repository: [Object],
      cache: [Map]
    },
    logger: CheckpointLogger {
      error: [Function (anonymous)],
      warn: [Function (anonymous)],
      info: [Function (anonymous)],
      debug: [Function (anonymous)],
      trace: [Function (anonymous)],
      includeDebug: true,
      includeTrace: false
    }
  },
  targetBranch: 'setup-release-please',
  repositoryConfig: {
    '.': {
      releaseType: 'java-yoshi',
      bumpMinorPreMajor: false,
      bumpPatchForMinorPreMajor: false,
      prereleaseType: undefined,
      versioning: undefined,
      changelogSections: undefined,
      changelogPath: 'CHANGELOG.md',
      changelogHost: undefined,
      changelogType: undefined,
      releaseAs: undefined,
      skipGithubRelease: undefined,
      draft: false,
      draftPullRequest: undefined,
      prerelease: false,
      component: undefined,
      packageName: undefined,
      versionFile: undefined,
      extraFiles: undefined,
      includeComponentInTag: false,
      includeVInTag: undefined,
      tagSeparator: undefined,
      pullRequestTitlePattern: undefined,
      pullRequestHeader: undefined,
      pullRequestFooter: undefined,
      componentNoSpace: undefined,
      separatePullRequests: false,
      skipSnapshot: undefined,
      initialVersion: undefined,
      extraLabels: undefined,
      excludePaths: undefined
    }
  },
  releasedVersions: {
    '.': Version {
      major: 1,
      minor: 30,
      patch: 1,
      preRelease: undefined,
      build: undefined
    }
  },
  manifestPath: '.release-please-manifest.json',
  separatePullRequests: false,
  alwaysUpdate: false,
  fork: false,
  signoffUser: undefined,
  releaseLabels: [ 'autorelease: tagged' ],
  labels: [ 'autorelease: pending' ],
  skipLabeling: false,
  sequentialCalls: false,
  snapshotLabels: [ 'autorelease: snapshot' ],
  bootstrapSha: undefined,
  lastReleaseSha: undefined,
  draft: undefined,
  draftPullRequest: undefined,
  groupPullRequestTitlePattern: 'chore(${branch}): release ${version}',
  releaseSearchDepth: 400,
  commitSearchDepth: 500,
  logger: CheckpointLogger {
    error: [Function (anonymous)],
    warn: [Function (anonymous)],
    info: [Function (anonymous)],
    debug: [Function (anonymous)],
    trace: [Function (anonymous)],
    includeDebug: true,
    includeTrace: false
  },
  plugins: [],
  pullRequestOverflowHandler: FilePullRequestOverflowHandler {
    github: GitHub {
      getCommitFiles: [AsyncFunction (anonymous)],
      graphqlRequest: [AsyncFunction (anonymous)],
      findFilesByFilenameAndRef: [AsyncFunction (anonymous)],
      findFilesByGlobAndRef: [AsyncFunction (anonymous)],
      createPullRequest: [AsyncFunction (anonymous)],
      getPullRequest: [AsyncFunction (anonymous)],
      updatePullRequest: [AsyncFunction (anonymous)],
      findFilesByExtensionAndRef: [AsyncFunction (anonymous)],
      createRelease: [AsyncFunction (anonymous)],
      commentOnIssue: [AsyncFunction (anonymous)],
      removeIssueLabels: [AsyncFunction (anonymous)],
      addIssueLabels: [AsyncFunction (anonymous)],
      repository: [Object],
      octokit: [OctokitWithDefaults],
      request: [Function],
      graphql: [Function],
      fileCache: [RepositoryFileCache],
      logger: [CheckpointLogger]
    },
    logger: CheckpointLogger {
      error: [Function (anonymous)],
      warn: [Function (anonymous)],
      info: [Function (anonymous)],
      debug: [Function (anonymous)],
      trace: [Function (anonymous)],
      includeDebug: true,
      includeTrace: false
    }
  }
}
diegomarquezp@diegomarquezp1:~/google/google-auth-library-java$ echo $?
0

Follow ups

  • double check that the main release PR updates the readmes once this one is merged

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 16, 2025
@diegomarquezp diegomarquezp marked this pull request as ready for review January 16, 2025 18:43
@diegomarquezp diegomarquezp requested review from a team as code owners January 16, 2025 18:43
@diegomarquezp diegomarquezp marked this pull request as draft January 16, 2025 18:48
@diegomarquezp diegomarquezp marked this pull request as ready for review January 16, 2025 18:52
@sonarqubecloud
Copy link

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Diego for fixing this!
super nit: Could you update the link to "docs on bootstrapping config" in the description? It's pointing to sdk-platform-java

@diegomarquezp diegomarquezp merged commit 2f2c269 into main Jan 16, 2025
17 checks passed
@diegomarquezp diegomarquezp deleted the setup-release-please branch January 16, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release please config is not fully setup, versions in readme files are not updated

2 participants