Skip to content

chore: Migrate deprecated Guava Charsets to JDK's StandardCharsets#1456

Merged
lqiu96 merged 2 commits intogoogleapis:mainfrom
kluever:patch-1
Sep 20, 2024
Merged

chore: Migrate deprecated Guava Charsets to JDK's StandardCharsets#1456
lqiu96 merged 2 commits intogoogleapis:mainfrom
kluever:patch-1

Conversation

@kluever
Copy link
Copy Markdown
Contributor

@kluever kluever commented Aug 2, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [n/a] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #n/a ☕️

If you write sample code, please follow the samples format.

@kluever kluever requested a review from a team August 2, 2024 20:42
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Aug 2, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Aug 2, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 5, 2024

@lqiu96 lqiu96 changed the title Migrate deprecated Guava Charsets to JDK's StandardCharsets chore: Migrate deprecated Guava Charsets to JDK's StandardCharsets Sep 20, 2024
@lqiu96 lqiu96 requested a review from a team September 20, 2024 16:51
@sonarqubecloud
Copy link
Copy Markdown

@lqiu96 lqiu96 merged commit 12c0188 into googleapis:main Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants