Fix NPE deserializing ServiceAccountCredentials#132
Conversation
|
@garrettjonesgoogle @lesv @anthmgoogle: can someone review this? This bug breaks authentication via service accounts for dataflow io connectors. Please see b/65304954 for details |
|
@vchudnov-g could you comment on why the |
|
As per my comments, the method seemed to be unused. If this change bringing I'm still curious, though, where/how does |
|
OK, thanks for the pointer. The fix is fine by me. Maybe include a comment saying the method is needed for the Serializable interface? I get that this is the Way Things Are Done, but these types of magic invocations seem really counterintuitive and lend themselves to issues like these..... At any rate, my apologies for breaking things. |
Deserialization of ServiceAccoutnCredentials broke in 0.7.0 via this commit:
432ee7e#diff-e186a7a41155398a3502025e16ac1508L479
It removed the java deserialization hook readObject to properly deserialize the transient transportFactory field.
This PR reverts that change and adds a test