fix: refactor compute and cloudshell credentials to pass quota project to base class#1284
Merged
TimurSadykov merged 6 commits intogoogleapis:mainfrom Jan 17, 2024
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
TimurSadykov
suggested changes
Oct 2, 2023
TimurSadykov
left a comment
TimurSadykov
left a comment
There was a problem hiding this comment.
Overall looks good, except margin visibility
sai-sunder-s
force-pushed
the
computequota
branch
from
150b721 to
d730a36
Compare
product-auto-label
Bot
added
size: s
sai-sunder-s
changed the title
product-auto-label
Bot
added
size: m
sai-sunder-s
force-pushed
the
computequota
branch
from
e9e49e2 to
8d9c663
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently quota project that is set in the builder is dropped when build() is called for cloudshell and gce creds because the constructors are not rolling up the builders upto the base class.