Skip to content

test: expose test-jar and mock classes in oauth2#1224

Merged
diegomarquezp merged 9 commits intomainfrom
oauth2-testlib
Jun 23, 2023
Merged

test: expose test-jar and mock classes in oauth2#1224
diegomarquezp merged 9 commits intomainfrom
oauth2-testlib

Conversation

@diegomarquezp
Copy link
Copy Markdown
Contributor

@diegomarquezp diegomarquezp commented Jun 20, 2023

We need to expose some test utils to be used in googleapis/sdk-platform-java#1642

Basically to allow GdchCredentials to be refreshed via fake transport

BEGIN_COMMIT_OVERRIDE
feat: expose test-jar and mock classes in oauth2
END_COMMIT_OVERRIDE

@diegomarquezp diegomarquezp requested review from a team June 20, 2023 17:00
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jun 20, 2023
@diegomarquezp diegomarquezp requested review from TimurSadykov and removed request for TimurSadykov June 21, 2023 14:24
Comment thread appengine/pom.xml Outdated
Comment thread oauth2_http/javatests/com/google/auth/oauth2/MockHttpTransportFactory.java Outdated
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to approve the PR, please resolve the comments before merging.

@diegomarquezp diegomarquezp requested a review from blakeli0 June 21, 2023 22:01
Copy link
Copy Markdown

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegomarquezp diegomarquezp merged commit 12e8db6 into main Jun 23, 2023
@diegomarquezp diegomarquezp deleted the oauth2-testlib branch June 23, 2023 03:58
@diegomarquezp diegomarquezp changed the title test: expose test-jar and mock classes in oauth2 feat: expose test-jar and mock classes in oauth2 Jun 27, 2023
@diegomarquezp diegomarquezp added kokoro:force-run Add this label to force Kokoro to re-run the tests. release-please:force-run To run release-please and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 27, 2023
@release-please release-please Bot removed the release-please:force-run To run release-please label Jun 27, 2023
@diegomarquezp diegomarquezp changed the title feat: expose test-jar and mock classes in oauth2 test: expose test-jar and mock classes in oauth2 Jun 27, 2023
@diegomarquezp diegomarquezp added the release-please:force-run To run release-please label Jun 27, 2023
@release-please release-please Bot removed the release-please:force-run To run release-please label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants