chore: using full package names to avoid incorrect import merge#1193
Merged
arithmetic1728 merged 15 commits intomainfrom Apr 7, 2023
Merged
chore: using full package names to avoid incorrect import merge#1193arithmetic1728 merged 15 commits intomainfrom
arithmetic1728 merged 15 commits intomainfrom
Conversation
product-auto-label
Bot
added
size: u
product-auto-label
Bot
added
size: s
added 3 commits
April 6, 2023 19:09
TimurSadykov
changed the title
TimurSadykov
changed the title
TimurSadykov
changed the title
lsirac
approved these changes
Apr 7, 2023
arithmetic1728
approved these changes
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding full package names for ExternalAccountCredentials to avoid imports mix-up due to nested classes.
Long term fix would be to move out nested classes along with next major release. Issue: googleapis/google-cloud-java#12601