Skip to content

chore: updating owl bot rule to exclude file from style check#1190

Merged
TimurSadykov merged 10 commits intomainfrom
stim-imports
Apr 4, 2023
Merged

chore: updating owl bot rule to exclude file from style check#1190
TimurSadykov merged 10 commits intomainfrom
stim-imports

Conversation

@TimurSadykov
Copy link
Copy Markdown

@TimurSadykov TimurSadykov commented Apr 3, 2023

No description provided.

@TimurSadykov TimurSadykov requested review from a team April 3, 2023 01:33
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Apr 3, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Apr 3, 2023
@TimurSadykov TimurSadykov added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2023
@TimurSadykov TimurSadykov changed the title fix: changing import order to fix bogus import error fix: updating owl bot rule to exclude file from style check Apr 3, 2023
sai-sunder-s
sai-sunder-s reviewed Apr 4, 2023
View reviewed changes
Comment thread owlbot.py
".kokoro/presubmit/graalvm-native.cfg",
".kokoro/presubmit/graalvm-native-17.cfg"
".kokoro/presubmit/graalvm-native-17.cfg",
"oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java"
Copy link
Copy Markdown
Contributor

@sai-sunder-s sai-sunder-s Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file being excluded?

@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 4, 2023
@TimurSadykov TimurSadykov changed the title fix: updating owl bot rule to exclude file from style check chore: updating owl bot rule to exclude file from style check Apr 4, 2023
@TimurSadykov TimurSadykov merged commit 51fd1fa into main Apr 4, 2023
@TimurSadykov TimurSadykov deleted the stim-imports branch April 4, 2023 23:17
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Apr 5, 2023 •
edited
Loading

Kokoro - Test: Integration — Build failed (link):

[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ google-auth-library-oauth2-http ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 57 source files to /tmpfs/src/github/google-auth-library-java/oauth2_http/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /tmpfs/src/github/google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java:[72,53] cannot find symbol
  symbol:   class Serializable
  location: class com.google.auth.oauth2.ExternalAccountCredentials

@TimurSadykov TimurSadykov mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s left review comments

@clundin25 clundin25 clundin25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TimurSadykov @suztomo @sai-sunder-s @clundin25 @kokoro-team