feat: adds external account authorized user credentials#1129
Merged
lsirac merged 6 commits intogoogleapis:mainfrom Jan 21, 2023
Merged
feat: adds external account authorized user credentials#1129lsirac merged 6 commits intogoogleapis:mainfrom
lsirac merged 6 commits intogoogleapis:mainfrom
Conversation
TimurSadykov
suggested changes
Jan 20, 2023
TimurSadykov
left a comment
TimurSadykov
left a comment
There was a problem hiding this comment.
Overall LGTM, only test coverage comments
TimurSadykov
approved these changes
Jan 21, 2023
TimurSadykov
left a comment
TimurSadykov
left a comment
There was a problem hiding this comment.
LGTM, but we might fix codecoverage later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for external account authorized user credentials.
See go/gcloud-3pi-headful.