fix: Use Futures.getDone() instead of Future.get() in listener#1109
Merged
TimurSadykov merged 4 commits intogoogleapis:mainfrom Jan 25, 2023
Merged
fix: Use Futures.getDone() instead of Future.get() in listener#1109TimurSadykov merged 4 commits intogoogleapis:mainfrom
TimurSadykov merged 4 commits intogoogleapis:mainfrom
Conversation
Listeners for Futures should generally use Futures.addCallback() or Futures.getDone() when called. This makes it clear they won't block and allows tooling to know it will never block. cl/492555987
TimurSadykov
approved these changes
Dec 8, 2022
TimurSadykov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listeners for Futures should generally use Futures.addCallback() or Futures.getDone() when called. This makes it clear they won't block and allows tooling to know it will never block.
cl/492555987