Make OAuth2Credentials#refreshTask volatile#1046
Closed
petedmarsh wants to merge 1 commit intogoogleapis:mainfrom
Closed
Make OAuth2Credentials#refreshTask volatile#1046petedmarsh wants to merge 1 commit intogoogleapis:mainfrom
petedmarsh wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4 tasks
The synchronization on the lock is not enough to ensure that all threads
have latest value of "refreshTask" which means it is possible for two
refresh tasks to run at once:
// OAuth2Credentials#L247
synchronized (lock) {
if (refreshTask != null) {
return new AsyncRefreshResult(refreshTask, false);
}
This is similar to why this.value has to be volatile.
petedmarsh
force-pushed
the
make-refresh-task-volatile
branch
from
c7b1ad2 to
63565ae
Compare
Author
|
I was wrong the synchronized block enough ok as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synchronization on the lock is not enough to ensure that all threads have latest value of "refreshTask" which means it is possible for two refresh tasks to run at once:
This is similar to why this.value has to be volatile.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.