feat: add support for universe domain #4675
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
generator/tests/testdata/golden/php/default/endpoints_google_owned.golden
Show resolved
Hide resolved
| base_path = url_parts.path | ||
| if not root_url: | ||
| if root_url: | ||
| self._api.SetTemplateValue('rootUrlTemplate', root_url.replace('googleapis.com', 'UNIVERSE_DOMAIN')) |
There was a problem hiding this comment.
This might break though, if users have a rooturl like:
usergoogleapis.com, it would be changed to userUNIVERSE_DOMAIN.
There was a problem hiding this comment.
I am not sure though how big of a usecase this is... a client using TPC and their domain name has googleapis.com
There was a problem hiding this comment.
we could replace .googleapis.com with .UNIVERSE_DOMAIN if you think that would be safer.
bshaffer
force-pushed
the
universe-domain
branch
from
0d0bf65 to
6889d28
Compare
2 participants
adds new
$rootUrlTemplateproperty to all service classes in order to support the universe domain option in googleapis/google-api-php-client#2563