fix: convert Finder lazy iterator to array before deletion #2663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finder returns a live iterator that updates as files and directories are removed, causing some items to be skipped during deletion. This change converts the iterator to an array using `iterator_to_array()`, fixing the issue where not all files were deleted in one pass. Closes googleapis/google-api-php-client-services#6502
bshaffer
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finder returns a live iterator that updates as files and directories are removed, causing some items to be skipped during deletion. This change converts the iterator to an array using
iterator_to_array(), fixing the issue where not all files were deleted in one pass.Closes googleapis/google-api-php-client-services#6502