Add correct type for $jwt, should be JWT #2648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jose-ochoa
force-pushed
the
2641-Fix-JWT-Type-Error
branch
2 times, most recently
from
ff50926 to
1e0adb1
Compare
jose-ochoa
force-pushed
the
2641-Fix-JWT-Type-Error
branch
from
1e0adb1 to
74f2b17
Compare
bshaffer
approved these changes
Dec 16, 2024
bshaffer
approved these changes
Dec 16, 2024
bshaffer
reviewed
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2641
This pull request includes changes to the
Verifyclass in thesrc/AccessToken/Verify.phpfile to improve type safety by updating the type hints for thejwtproperty and constructor parameter.Type safety improvements:
src/AccessToken/Verify.php: Changed the type hint of thejwtproperty from\Firebase\JWT\JWTtoJWT.src/AccessToken/Verify.php: Updated the type hint of thejwtparameter in the constructor from?stringto?JWT.