feat: Add the protected apiVersion property #2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Hectorhammett
force-pushed
the
api-versioning
branch
3 times, most recently
from
cf8ee77 to
4f094af
Compare
noahdietz
approved these changes
Apr 22, 2024
bshaffer
reviewed
Apr 22, 2024
Contributor
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
It's a small feature, but I'd still like to see a test for it!
Hectorhammett
force-pushed
the
api-versioning
branch
2 times, most recently
from
d05024a to
9c499d9
Compare
Hectorhammett
force-pushed
the
api-versioning
branch
from
9c499d9 to
fd01972
Compare
Contributor
Author
|
@bshaffer Added! |
bshaffer
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the protected
apiVersionproperty to theResourceclass to support the new api version header.