chore: drop support for PHP 7.4 #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hectorhammett
approved these changes
May 16, 2024
Contributor
|
The 7.X tests are still running, Should we remove them? What is the protocol here @bshaffer |
Contributor
|
README also needs to be changed: google-api-php-client/README.md Line 28 in 7e79f3d |
Contributor
|
@Hectorhammett that is happening because php7.4 is mentioned in the repo settings. It can be fixed by removing it, but only admin can see/do this change. |
vishwarajanand
approved these changes
May 17, 2024
Contributor
vishwarajanand
left a comment
vishwarajanand
left a comment
There was a problem hiding this comment.
Approving to unblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.