-
Notifications
You must be signed in to change notification settings - Fork 2k
drive API: file upload stream backpressure issue #1354
Copy link
Copy link
Closed
googleapis/nodejs-googleapis-common
#67Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
It seems that upload stream backpressure is not handled properly.
In the following example, the stream is consumed very quickly (100% reached in 2 seconds) whereas the upload take a while... (that is expected with my ADSL connexion). This mean that the whole file is loaded into memory then sent gradually, which disables the benefit of the streams.
Using your example:
Configuration:
Node.js v10.10.0
googleapis 33.0.0
OS windows7