Skip to content

feat: Provide HttpTransport support for google certificates with apache HTTP client v5 (#2497)#2503

Merged
ldetmer merged 24 commits intomainfrom
apache-v5-upgrade
Aug 27, 2024
Merged

feat: Provide HttpTransport support for google certificates with apache HTTP client v5 (#2497)#2503
ldetmer merged 24 commits intomainfrom
apache-v5-upgrade

Conversation

@ldetmer
Copy link
Copy Markdown
Contributor

@ldetmer ldetmer commented Aug 14, 2024 •
edited
Loading

Fixes #2497 ☕️

@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Aug 14, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Aug 14, 2024
@ldetmer ldetmer force-pushed the apache-v5-upgrade branch from cafe781 to ce808d7 Compare August 14, 2024 20:48
burkedavison
burkedavison reviewed Aug 22, 2024
View reviewed changes
Comment thread google-api-client-apache-v5/pom.xml Outdated
Comment thread google-api-client-apache-v5/pom.xml Outdated
Comment thread ...-v5/src/main/java/com/google/api/client/googleapis/apache/v5/GoogleApache5HttpTransport.java Outdated
Comment thread ...le-api-client/src/test/java/com/google/api/client/googleapis/mtls/MtlsTransportBaseTest.java Outdated
@ldetmer ldetmer marked this pull request as ready for review August 22, 2024 20:52
@ldetmer ldetmer requested review from a team and diegomarquezp August 22, 2024 20:52
diegomarquezp
diegomarquezp reviewed Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! Just a few comments + a nit on the pom and docs

Comment thread docs/component-modules.md Outdated
Comment thread google-api-client-apache-v5/pom.xml Outdated
Comment thread google-api-client-apache-v5/pom.xml Outdated
Comment thread ...c/test/java/com/google/api/client/googleapis/apache/v5/ITGoogleApache5HttpTransportTest.java
Copy link
Copy Markdown
Contributor

@diegomarquezp diegomarquezp Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format checker will probably complain for a missing license header in this file.

Copy link
Copy Markdown
Contributor Author

@ldetmer ldetmer Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you're looking at old version of the file?

Copy link
Copy Markdown
Contributor

@diegomarquezp diegomarquezp Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed! Please disregard.

@ldetmer ldetmer requested a review from diegomarquezp August 23, 2024 19:58
@ldetmer ldetmer merged commit 0d39b43 into main Aug 27, 2024
@ldetmer ldetmer deleted the apache-v5-upgrade branch August 27, 2024 15:52
@release-please release-please Bot mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burkedavison burkedavison burkedavison left review comments

@diegomarquezp diegomarquezp diegomarquezp approved these changes

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Start using core5 and client5 libraries as core(4) and client(4) haven't changed since 2022

3 participants

@ldetmer @diegomarquezp @burkedavison