ci: fix the google style error in lint task in GitHub Actions#1695
Closed
suztomo wants to merge 4 commits intogoogleapis:masterfrom
Closed
ci: fix the google style error in lint task in GitHub Actions#1695suztomo wants to merge 4 commits intogoogleapis:masterfrom
suztomo wants to merge 4 commits intogoogleapis:masterfrom
Conversation
|
Warning: This pull request is touching the following templated files:
|
google-cla
Bot
added
the
cla: yes
Member
Author
|
Hmm. The file seems auto-generated. I guess I shouldn't touch this.
|
Member
Author
|
The lint passed.
|
suztomo
commented
Feb 9, 2021
| new GoogleIdTokenVerifier.Builder( | ||
| new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(), | ||
| new GsonFactory()) | ||
| new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(), new GsonFactory()) |
Member
Author
There was a problem hiding this comment.
mvn com.coveo:fmt-maven-plugin:format changed this line.
Comment on lines
-73
to
+72
| new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(), | ||
| new GsonFactory()) | ||
| new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(), new GsonFactory()) |
Member
Author
There was a problem hiding this comment.
mvn com.coveo:fmt-maven-plugin:format changed this line.
Comment on lines
104
to
105
| GooglePublicKeysManager certs = | ||
| new GooglePublicKeysManager.Builder( | ||
| new PublicCertsMockHttpTransport(), new GsonFactory()) | ||
| new GooglePublicKeysManager.Builder(new PublicCertsMockHttpTransport(), new GsonFactory()) | ||
| .build(); |
Member
Author
There was a problem hiding this comment.
mvn com.coveo:fmt-maven-plugin:format changed this line.
| import com.google.api.client.googleapis.testing.services.MockGoogleClient; | ||
| import com.google.api.client.googleapis.testing.services.MockGoogleClientRequest; | ||
| import com.google.api.client.http.ByteArrayContent; | ||
| import com.google.api.client.http.ExponentialBackOffPolicy; |
Member
Author
There was a problem hiding this comment.
mvn com.coveo:fmt-maven-plugin:format changed this line.
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Nov 7, 2022
* chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: googleapis/synthtool@74d0956 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
…2178) * chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
blakeli0
pushed a commit
that referenced
this pull request
Dec 16, 2022
…2178) * chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
blakeli0
pushed a commit
that referenced
this pull request
Dec 16, 2022
…2178) * chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️