Skip to content

fix(transport): fix memory leak in grpc.Dial #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quartzmo merged 3 commits into from
Jan 3, 2024
Merged

fix(transport): fix memory leak in grpc.Dial #2329

quartzmo merged 3 commits into from
Jan 3, 2024
+24 −2

Conversation

@quartzmo
Copy link
Member

@quartzmo quartzmo commented Jan 2, 2024

  • Memoize otelgrpc.NewClientHandler for reuse

fixes: #2321

@quartzmo
fix(transport): fix memory leak in grpc.Dial
98bfe5a 
* Memoize otelgrpc.NewClientHandler for reuse

fixes: googleapis#2321
@quartzmo quartzmo requested a review from a team as a code owner January 2, 2024 22:08
codyoss
codyoss requested changes Jan 2, 2024
View reviewed changes
@quartzmo quartzmo enabled auto-merge (squash) January 3, 2024 16:26
@quartzmo quartzmo merged commit 240f763 into googleapis:main Jan 3, 2024
@release-please release-please bot mentioned this pull request Jan 3, 2024
Merged
This was referenced Jan 3, 2024
Merged
Closed
@dashpole dashpole mentioned this pull request Jan 10, 2024
Merged
quartzmo added a commit to quartzmo/google-cloud-go that referenced this pull request Dec 29, 2025
@quartzmo
fix(auth): remove singleton and restore normal usage of otelgrpc.clie…
e27ca49 
…ntHandler

refs: googleapis/google-api-go-client/issues/2321
refs: googleapis/google-api-go-client/pull/2329
refs: open-telemetry/opentelemetry-go-contrib#4226
quartzmo added a commit to quartzmo/google-cloud-go that referenced this pull request Dec 29, 2025
@quartzmo
fix(auth): remove singleton and restore normal usage of otelgrpc.clie…
5f669b0 
…ntHandler

refs: googleapis/google-api-go-client#2321
refs: googleapis/google-api-go-client#2329
refs: open-telemetry/opentelemetry-go-contrib#4226
@quartzmo quartzmo mentioned this pull request Dec 29, 2025
Merged
quartzmo added a commit to quartzmo/google-api-go-client that referenced this pull request Dec 29, 2025
@quartzmo
fix(transport): remove singleton and restore normal usage of otelgrpc…
a83f3f2 
….clientHandler

refs: googleapis#2321
refs: googleapis#2329
refs: open-telemetry/opentelemetry-go-contrib#4226
@quartzmo quartzmo mentioned this pull request Dec 29, 2025
Merged
quartzmo added a commit that referenced this pull request Dec 30, 2025
@quartzmo
fix(transport): remove singleton and restore normal usage of otelgrpc…
24fbfcb 
….clientHandler (#3424)

refs: #2321
refs: #2329
refs: open-telemetry/opentelemetry-go-contrib#4226
quartzmo added a commit to googleapis/google-cloud-go that referenced this pull request Dec 30, 2025
@quartzmo
fix(auth): remove singleton and restore normal usage of otelgrpc.clie…
673d4b0 
…ntHandler (#13522)

refs: googleapis/google-api-go-client#2321
refs: googleapis/google-api-go-client#2329
refs: open-telemetry/opentelemetry-go-contrib#4226
@release-please release-please bot mentioned this pull request Dec 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory leak in v0.154.0

2 participants

@quartzmo @codyoss