feat: add checksums for single chunk json uploads (#3448)

krishnamd-jkp · web-flow · commit 0f1cb7b9b71b · 2026-02-03T08:25:09.000-08:00
* feat: add checksums for single chunk json uploads

* minor fixes

* nit changes
diff --git a/google-api-go-generator/gen.go b/google-api-go-generator/gen.go
@@ -2280,6 +2280,17 @@ func (meth *Method) generateCode() {
 	} else {
 		pn(`reqHeaders := gensupport.SetHeaders(c.s.userAgent(), %s, c.header_, "x-goog-api-version", %q)`, contentType, apiVersion)
 	}
+	if meth.supportsMediaUpload() && meth.api.Name == "storage" {
+		comment = "Set auto checksum in case of a single chunk upload if enabled."
+		p("%s", asComment("", comment))
+		pn("if c.object != nil &&")
+		pn(`	c.object.Crc32c == "" &&`)
+		pn("	c.mediaInfo_ != nil &&")
+		pn(`	c.mediaInfo_.UploadType() == "multipart" &&`)
+		pn("	c.mediaInfo_.ChecksumEnabled() {")
+		pn("	c.object.Crc32c = c.mediaInfo_.GetAutoChecksum()")
+		pn("}")
+	}
 	if httpMethod == "GET" {
 		pn(`if c.ifNoneMatch_ != "" {`)
 		pn(` reqHeaders.Set("If-None-Match",  c.ifNoneMatch_)`)
diff --git a/internal/gensupport/media.go b/internal/gensupport/media.go
@@ -198,6 +198,22 @@ func (mi *MediaInfo) UploadType() string {
 	return "resumable"
 }
 
+// ChecksumEnabled returns if auto checksum is enabled in buffer.
+func (mi *MediaInfo) ChecksumEnabled() bool {
+	return mi.buffer != nil && mi.buffer.enableAutoChecksum
+}
+
+// GetAutoChecksum returns the computed auto checksum from buffer (if enabled).
+// Make sure whole data is written and read from the buffer before calling this
+// function to get correct checksum of the data.
+func (mi *MediaInfo) GetAutoChecksum() string {
+	if mi.buffer != nil &&
+		mi.buffer.enableAutoChecksum {
+		return encodeUint32(mi.buffer.fullObjectChecksum)
+	}
+	return ""
+}
+
 // UploadRequest sets up an HTTP request for media upload. It adds headers
 // as necessary, and returns a replacement for the body and a function for http.Request.GetBody.
 func (mi *MediaInfo) UploadRequest(reqHeaders http.Header, body io.Reader) (newBody io.Reader, getBody func() (io.ReadCloser, error), cleanup func()) {
diff --git a/storage/v1/storage-gen.go b/storage/v1/storage-gen.go
