This repository was archived by the owner on Jun 24, 2024. It is now read-only.
fix: Fix support for streams without content-length property#491
Merged
danielbankhead merged 1 commit intomainfrom Jan 6, 2022
Merged
fix: Fix support for streams without content-length property#491danielbankhead merged 1 commit intomainfrom
danielbankhead merged 1 commit intomainfrom
Conversation
In `pumpify` the `prefinish` event is emitted when an upstream writer has ended
product-auto-label
Bot
added
the
api: storage
danielbankhead
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
1 task
Contributor
|
I'm assuming this is something that would have to change again if/when we ever removed |
Contributor
Author
|
@ddelgrosso1 correct, this is something that can be removed if |
ddelgrosso1
approved these changes
Jan 6, 2022
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [4.0.1](https://www.github.com/googleapis/gcs-resumable-upload/compare/v4.0.0...v4.0.1) (2022-01-06) ### Bug Fixes * Fix support for streams without content-length property ([#491](https://www.github.com/googleapis/gcs-resumable-upload/issues/491)) ([ac2f73b](https://www.github.com/googleapis/gcs-resumable-upload/commit/ac2f73b73e3afbc218ca99cbba3c598af4aefa9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
danielbankhead
pushed a commit
to googleapis/nodejs-storage
that referenced
this pull request
Jan 6, 2022
shaffeeullah
added a commit
to googleapis/nodejs-storage
that referenced
this pull request
Jan 6, 2022
* begin gcs-resumable-upload migration * moved test * moved system test * unit tests passing * fixed system tests * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removed log * rename * added index.ts * updated headers * temp file * 2022 headers * fixed buffer write * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * changed file name * pulled in new resumable code * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * closed stream * feat: Import fixes from `googleapis/gcs-resumable-upload/pull/491` Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Daniel Bankhead <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
pumpifytheprefinishevent is emitted when an upstream writer has ended, notend(as with standard streams).Fixes #490 🦕