Remove references to grpc.beta #127
Conversation
Also bump dependency on grpc up to 1.0.0.
Current coverage is 97.20% (diff: 100%)@@ master #127 diff @@
==========================================
Files 8 8
Lines 607 608 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 590 591 +1
Misses 17 17
Partials 0 0
|
| install_requires = [ | ||
| 'future>=0.15.2', | ||
| 'grpcio>=1.0rc1', | ||
| 'grpcio>=1.0.0', |
There was a problem hiding this comment.
Do we need to regenerate the auto-gen code with 1.0.0 to ensure everything still works correctly?
There was a problem hiding this comment.
Also, let's update test-requirements.txt.
There was a problem hiding this comment.
Do we need to regenerate the auto-gen code with 1.0.0 to ensure everything still works correctly?
Yes. GAX 0.13.0 will not work with older auto-gen code, since those have only beta entry points into the gRPC stub.
Also, let's update
test-requirements.txt.
Done
|
@geigerj FYI, I published a sample package of this at https://testpypi.python.org/pypi/google-gax |
|
LGTM. Can you update https://pypi.python.org/pypi/google-gax? Should be almost identical to |
|
Yay! |
4 participants
Also bump dependency on grpc up to 1.0.0.
Fixes #126