Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: remove .js file in protobuf export#1708

Merged
sofisl merged 1 commit intomainfrom
fixExportProtobuf
Mar 5, 2025
Merged

fix: remove .js file in protobuf export#1708
sofisl merged 1 commit intomainfrom
fixExportProtobuf

Conversation

@sofisl
Copy link
Copy Markdown
Contributor

@sofisl sofisl commented Mar 5, 2025

Now that gax uses subpaths for exports, we need this to conform to the correct subpath:

"./build/src/protobuf": "./build/src/protobuf.js"

@sofisl sofisl requested review from a team March 5, 2025 05:35
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Mar 5, 2025
@sofisl sofisl merged commit 113ca18 into main Mar 5, 2025
@sofisl sofisl deleted the fixExportProtobuf branch March 5, 2025 15:29
gcf-merge-on-green Bot pushed a commit that referenced this pull request Mar 6, 2025
🤖 I have created a release *beep* *boop*
---


## [1.0.0](https://togithub.com/googleapis/gax-nodejs/compare/gapic-tools-v0.4.6...gapic-tools-v1.0.0) (2025-03-05)


### ⚠ BREAKING CHANGES

* migrate gax to Node 18 ([#1699](https://togithub.com/googleapis/gax-nodejs/issues/1699))

### Bug Fixes

* bytes field should be typed as a Buffer ([#1652](https://togithub.com/googleapis/gax-nodejs/issues/1652)) ([a81663f](https://togithub.com/googleapis/gax-nodejs/commit/a81663fcdf69a42ee6335c78355b9c8cb11d6064))
* protobuf export path in compileProtos ([#1708](https://togithub.com/googleapis/gax-nodejs/issues/1708)) ([113ca18](https://togithub.com/googleapis/gax-nodejs/commit/113ca18d98f7915c5af05a893d0314744e3d15e1))


### Miscellaneous Chores

* migrate gax to Node 18 ([#1699](https://togithub.com/googleapis/gax-nodejs/issues/1699)) ([fc3eeaa](https://togithub.com/googleapis/gax-nodejs/commit/fc3eeaa574e171c445e0768b06df4ed087bf1f67))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants