This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: do not throw error on empty LRO response#1087
Merged
gcf-merge-on-green[bot] merged 1 commit intomasterfrom Aug 18, 2021
Merged
fix: do not throw error on empty LRO response#1087gcf-merge-on-green[bot] merged 1 commit intomasterfrom
gcf-merge-on-green[bot] merged 1 commit intomasterfrom
Conversation
alexander-fenster
requested review from
a team,
JustinBeckwith and
summer-ji-eng
google-cla
Bot
added
the
cla: yes
4 tasks
JustinBeckwith
approved these changes
Aug 18, 2021
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
thanks for the quick turn around!
alexander-fenster
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.24.2](https://www.github.com/googleapis/gax-nodejs/compare/v2.24.1...v2.24.2) (2021-08-18) ### Bug Fixes * do not throw error on empty LRO response ([#1087](https://www.github.com/googleapis/gax-nodejs/issues/1087)) ([1978197](https://www.github.com/googleapis/gax-nodejs/commit/197819799f270d886b4372ff4c9b81acd39992b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/googleapis/nodejs-contact-center-insights/pull/34/files#r690783654. Some APIs end LRO without setting either result or error (but set
done: true), that condition was previously considered an error but looks like it's OK to just return an empty response object in this case.