Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/gax-nodejs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.29.3
Choose a base ref
...
head repository: googleapis/gax-nodejs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.29.4
Choose a head ref
  • 5 commits
  • 11 files changed
  • 4 contributors

Commits on Jan 13, 2022

  1. fix: support non-alphanumeric field name (#1165)

    Currently REST mode transcode doesn't support non-alphanumeric in the field name, and it cause [firestore test](https://github.com/googleapis/nodejs-firestore/blob/main/dev/system-test/firestore.ts#L754-L771) fails.
    
    code sample:
    ```
    test() {
        const ref = randomCol.doc('doc');
        return ref
          .set({'!.\\`': {'!.\\`': 'value'}})
          .then(() => {
            return ref.get();
          })
          .then(doc => {
            // SEE ERROR ON THIS LINE
            expect(doc.data()).to.deep.equal({'!.\\`': {'!.\\`': 'value'}});
            return ref.update(new 
    FieldPath('!.\\`', '!.\\`'), 'new-value');
          })
          .then(() => {
            return ref.get();
          })
          .then(doc => {
            expect(doc.data()).to.deep.equal({'!.\\`': {'!.\\`': 'new-value'}});
          });
    }
    ```
    
    Error
    ```
    AssertionError: expected { '.': { '.': 'value' } } to deeply equal { '!.\\`': { '!.\\`': 'value' } }
    ```
    summer-ji-eng authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    4f53efa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c6d916 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Configuration menu
    Copy the full SHA
    887cd20 View commit details
    Browse the repository at this point in the history
  2. build(node): switch back to keystore for publication (#1328) (#1168)

    Source-Link: googleapis/synthtool@89dd35d
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:89c5b2f3decec8ad64febbebea671076c119d1ab43700da380846a315600de8a
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    Co-authored-by: Summer Ji <[email protected]>
    3 people authored Jan 19, 2022
    Configuration menu
    Copy the full SHA
    6195790 View commit details
    Browse the repository at this point in the history
  3. chore(main): release 2.29.4 (#1166)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ### [2.29.4](v2.29.3...v2.29.4) (2022-01-19)
    
    
    ### Bug Fixes
    
    * support non-alphanumeric field name ([#1165](#1165)) ([4f53efa](4f53efa))
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    release-please[bot] authored Jan 19, 2022
    Configuration menu
    Copy the full SHA
    b9f9d7e View commit details
    Browse the repository at this point in the history
Loading