This repository was archived by the owner on Sep 26, 2023. It is now read-only.
gax-grpc: allow custom direct path service config#879
Closed
creamsoup wants to merge 4 commits intogoogleapis:masterfrom
Closed
gax-grpc: allow custom direct path service config#879creamsoup wants to merge 4 commits intogoogleapis:masterfrom
creamsoup wants to merge 4 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
============================================
- Coverage 78.63% 78.54% -0.09%
+ Complexity 1163 1159 -4
============================================
Files 203 203
Lines 5143 5113 -30
Branches 413 402 -11
============================================
- Hits 4044 4016 -28
+ Misses 925 923 -2
Partials 174 174 Continue to review full report at Codecov.
|
Author
|
cc @WeiranFang |
elharo
reviewed
Feb 27, 2020
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private static List<Map<String, ?>> checkAndJsonListOfObjects(Object listObject) { |
Contributor
There was a problem hiding this comment.
this doesn't sound right: checkAndJsonListOfObjects?
Author
There was a problem hiding this comment.
oops i was debating checkAndGet or check, somehow the and survived. thanks!
…ervice_config_for_direct_path
Contributor
|
Closed in preference of #1235. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change allows
gax-grpcusers to specify service config for (mostly) more advanced direct path configuration. e.g. using different load balancing policy. by default, behavior remains same as today.