This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Small refactoring for v2.Batcher API#765
Merged
igorbernstein2 merged 2 commits intogoogleapis:masterfrom Jul 29, 2019
Merged
Conversation
- Added braces for if block(missed in the last PR). - Language edit for BatchingSettings & BatcherImpl Javadoc. - Removed duplicate unit test case. - Removed unnecessary usage of Mockito for BatcherImplTest.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
============================================
+ Coverage 78.14% 78.15% +<.01%
Complexity 1101 1101
============================================
Files 198 198
Lines 4832 4833 +1
Branches 383 383
============================================
+ Hits 3776 3777 +1
Misses 886 886
Partials 170 170
Continue to review full report at Codecov.
|
igorbernstein2
approved these changes
Jul 29, 2019
This was referenced Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @igorbernstein2
@kolea2 Could you please review this, and merge if looks good to you.