Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

gax: remove deprecated warnings.#759

Merged
igorbernstein2 merged 2 commits intogoogleapis:masterfrom
pmakani:removed-deprecated-gax
Aug 1, 2019
Merged

gax: remove deprecated warnings.#759
igorbernstein2 merged 2 commits intogoogleapis:masterfrom
pmakani:removed-deprecated-gax

Conversation

@pmakani
Copy link
Copy Markdown
Contributor

@pmakani pmakani commented Jul 11, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 11, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2019

Codecov Report

Merging #759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #759   +/-   ##
=========================================
  Coverage     77.94%   77.94%           
  Complexity     1099     1099           
=========================================
  Files           198      198           
  Lines          4806     4806           
  Branches        379      379           
=========================================
  Hits           3746     3746           
  Misses          889      889           
  Partials        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd82c7...52baf20. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #759   +/-   ##
=========================================
  Coverage     77.94%   77.94%           
  Complexity     1099     1099           
=========================================
  Files           198      198           
  Lines          4806     4806           
  Branches        379      379           
=========================================
  Hits           3746     3746           
  Misses          889      889           
  Partials        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd82c7...52baf20. Read the comment docs.

@rahulKQL
Copy link
Copy Markdown
Contributor

rahulKQL commented Jul 24, 2019

@kolea2 If you have a few mins of time, could you please have a look this PR.

Background: This is intended to address the deprecated method(isSameAs() --> isSameInstanceAs()) present in test classes after migrating to truth-1.0.

@rahulKQL
Copy link
Copy Markdown
Contributor

rahulKQL commented Aug 1, 2019

@igorbernstein2 If you have some spare time, Could you please have a look.

@igorbernstein2
Copy link
Copy Markdown
Contributor

igorbernstein2 commented Aug 1, 2019

I think this needs to be reviewed by @vam-google.

@rahulKQL rahulKQL requested a review from vam-google August 1, 2019 18:56
vam-google
vam-google approved these changes Aug 1, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorbernstein2 igorbernstein2 merged commit 93cb491 into googleapis:master Aug 1, 2019
@pmakani pmakani deleted the removed-deprecated-gax branch August 12, 2019 05:14
This was referenced Aug 16, 2019
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmakani @rahulKQL @igorbernstein2 @vam-google @googlebot