Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Builder parameterization, endpoint-setting functionality, other#414

Merged
garrettjonesgoogle merged 3 commits intogoogleapis:masterfrom
garrettjonesgoogle:master
Nov 7, 2017
Merged

Builder parameterization, endpoint-setting functionality, other#414
garrettjonesgoogle merged 3 commits intogoogleapis:masterfrom
garrettjonesgoogle:master

Conversation

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle commented Nov 6, 2017

No description provided.

This was referenced Nov 6, 2017
Merged
Merged
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 6, 2017 •
edited
Loading

Codecov Report

Merging #414 into master will decrease coverage by 0.66%.
The diff coverage is 68.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #414      +/-   ##
============================================
- Coverage     70.68%   70.02%   -0.67%     
- Complexity      630      634       +4     
============================================
  Files           134      134              
  Lines          2893     2916      +23     
  Branches        218      221       +3     
============================================
- Hits           2045     2042       -3     
- Misses          770      795      +25     
- Partials         78       79       +1
Impacted Files Coverage Δ Complexity Δ
...ax/longrunning/OperationResponsePollAlgorithm.java 66.66% <ø> (ø) 5 <0> (ø) ⬇️
...java/com/google/api/gax/rpc/InternalException.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...om/google/api/gax/batching/BatchingThresholds.java 80% <ø> (ø) 1 <0> (ø) ⬇️
.../google/api/gax/rpc/OperationCheckingCallable.java 81.25% <ø> (ø) 4 <0> (ø) ⬇️
.../google/api/gax/retrying/NonCancellableFuture.java 75% <ø> (ø) 5 <0> (ø) ⬇️
...m/google/api/gax/httpjson/ApiMethodDescriptor.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../com/google/api/gax/rpc/OperationCallableImpl.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...in/java/com/google/api/gax/rpc/BatcherFactory.java 95.12% <ø> (ø) 9 <0> (ø) ⬇️
...in/java/com/google/api/gax/core/GaxProperties.java 50% <ø> (ø) 2 <0> (ø) ⬇️
...com/google/api/gax/core/FixedExecutorProvider.java 66.66% <ø> (ø) 2 <0> (ø) ⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b217609...77e6f50. Read the comment docs.

michaelbausor
michaelbausor reviewed Nov 7, 2017
View reviewed changes
Comment thread benchmark/src/main/java/com/google/api/gax/grpc/CallableBenchmark.java
@@ -1,5 +1,5 @@
/*
* Copyright 2017, Google Inc. All rights reserved.
* Copyright 2017, Google LLC All rights reserved.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

michaelbausor
michaelbausor reviewed Nov 7, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments only, otherwise LGTM

Comment thread gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcExtraHeaderData.java Outdated

/** This class provides grpc-specific data to put on the x-goog-api-client header. */
@BetaApi
@BetaApi("The surface for customizing headers is not stable yet and my change in the future.")

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread gax/src/main/java/com/google/api/gax/rpc/ClientSettings.java
}

@SuppressWarnings("unchecked")
protected B self() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
}

@Override
public TransportChannelProvider withEndpoint(String endpoint) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle garrettjonesgoogle merged commit 2694045 into googleapis:master Nov 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@michaelbausor michaelbausor michaelbausor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettjonesgoogle @codecov-io @michaelbausor