[DIFF PR] showing diffs for moving code from gax-grpc to gax#374
[DIFF PR] showing diffs for moving code from gax-grpc to gax#374garrettjonesgoogle wants to merge 1 commit intogoogleapis:gax-httpjsonfrom
Conversation
|
|
||
| /** Class with utility methods to create instances of UnaryCallable with grpc-specific features. */ | ||
| /** | ||
| * Class with utility methods to create callable objects using provided settings. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
This particular diff PR is LGTM. There are still few concerns left in the original PR (Operation.getInitialFuture() removal, Transformers test, lots of testing classes in main/*/testing instead of test/ folder)
| ClientStreamingCallable<RequestT, ResponseT> createDirectClientStreamingCallable( | ||
| MethodDescriptor<RequestT, ResponseT> methodDescriptor) { | ||
| return new GrpcDirectClientStreamingCallable<>(methodDescriptor); | ||
| public static CallableFactory create(TransportDescriptor transportDescriptor) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| OperationsStub operationsStub, | ||
| OperationCallSettings<RequestT, ResponseT, MetadataT, Operation> operationCallSettings) { | ||
| @InternalApi | ||
| class OperationCallableImpl<RequestT, ResponseT, MetadataT> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| initialContext = getClientContext(initialChannel, executor); | ||
| } | ||
|
|
||
| private static class ResponseTransformer implements ApiFunction<OperationSnapshot, Color> { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
closing diff PR. |
3 participants
This is a companion PR for #359 to show diffs in cases where git didn't match up files.