Add GaxPropertiesProvider as a utility class by shinfan · Pull Request #250 · googleapis/gax-java

shinfan · 2017-03-22T20:37:46Z

Separate the property loading functionality as a utility class so it can be easily reused in google-cloud-java.

More context: https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1790/files

codecov-io · 2017-03-22T20:40:31Z

Codecov Report

Merging #250 into master will decrease coverage by 0.28%.
The diff coverage is 64.7%.

@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     71.06%   70.78%   -0.29%     
  Complexity      527      527              
============================================
  Files            75       76       +1     
  Lines          2592     2601       +9     
  Branches        268      268              
============================================
- Hits           1842     1841       -1     
- Misses          647      656       +9     
- Partials        103      104       +1

Impacted Files	Coverage Δ	Complexity Δ
...gle/api/gax/grpc/InstantiatingChannelProvider.java	`49.42% <100%> (-4.43%)`	`10 <0> (-4)`
...com/google/api/gax/core/GaxPropertiesProvider.java	`53.84% <53.84%> (ø)`	`5 <5> (?)`
...java/com/google/api/gax/grpc/RetryingCallable.java	`85.18% <0%> (-1.86%)`	`6% <0%> (ø)`
...om/google/api/gax/retrying/RetryingFutureImpl.java	`82.25% <0%> (-1.62%)`	`13% <0%> (-1%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b454532...226447d. Read the comment docs.

Sign in to view

 package com.google.api.gax.grpc;

 import com.google.api.gax.core.CredentialsProvider;
+import com.google.api.gax.utils.PropertiesProvider;


Sign in to view

@@ -0,0 +1,73 @@
+/*
+ * Copyright 2016, Google Inc. All rights reserved.


Sign in to view

+/**
+ * Provides meta-data properties stored in gax.properties
+ */
+public class PropertiesProvider {


shinfan · 2017-03-22T21:01:40Z

PTAL @garrettjonesgoogle

garrettjonesgoogle

Be sure to update the commit message (the class name is out of date)

Sign in to view

+    try {
+      if (gaxProperties.isEmpty()) {
+        gaxProperties.load(
+            InstantiatingChannelProvider.class


Sign in to view

+ */
+package com.google.api.gax.core;
+
+import com.google.api.gax.grpc.InstantiatingChannelProvider;


shinfan · 2017-03-22T21:16:17Z

Commit msg updated. PTAL

garrettjonesgoogle · 2017-03-22T21:19:24Z

LGTM after tests pass.

shinfan and others added 3 commits March 22, 2017 12:34

Add PropertiesProvider as a utility class

74843ab

Bump version to 0.6.1-SNAPSHOT for development (googleapis#249)

4bbb000

Add PropertiesProvider as a utility class

3dc906b

shinfan requested review from garrettjonesgoogle and michaelbausor March 22, 2017 20:37

shinfan mentioned this pull request Mar 22, 2017

Add x-goog-api-client support to HTTP1.1 googleapis/google-cloud-java#1790

Merged

garrettjonesgoogle reviewed Mar 22, 2017

View reviewed changes

shinfan added 2 commits March 22, 2017 13:49

Update`

0feab5f

Merge branch 'master' of github.com:googleapis/gax-java

973a287

garrettjonesgoogle force-pushed the master branch from 973a287 to b454532 Compare March 22, 2017 20:54

shinfan added 4 commits March 22, 2017 13:56

Merge branch 'master' of github.com:shinfan/gax-java

ae38bf2

Remove merged files

21a8281

Merge branch 'master' of github.com:googleapis/gax-java

0143d76

Fix bad merge

d5509d5

garrettjonesgoogle reviewed Mar 22, 2017

View reviewed changes

Comment thread src/main/java/com/google/api/gax/core/GaxPropertiesProvider.java Outdated

try {

if (gaxProperties.isEmpty()) {

gaxProperties.load(

InstantiatingChannelProvider.class

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

shinfan changed the title ~~Add PropertiesProvider as a utility class~~ Add GaxPropertiesProvider as a utility class Mar 22, 2017

Fix class name

1a0b6c3

garrettjonesgoogle reviewed Mar 22, 2017

View reviewed changes

Comment thread src/main/java/com/google/api/gax/core/GaxPropertiesProvider.java Outdated

*/

package com.google.api.gax.core;

import com.google.api.gax.grpc.InstantiatingChannelProvider;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Clean unused import

226447d

shinfan merged commit 97eccff into googleapis:master Mar 22, 2017

		@@ -0,0 +1,73 @@
		/*
		* Copyright 2016, Google Inc. All rights reserved.

Conversation

shinfan commented Mar 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Mar 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Mar 22, 2017

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Mar 22, 2017

Uh oh!

garrettjonesgoogle commented Mar 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shinfan commented Mar 22, 2017 •

edited

Loading

codecov-io commented Mar 22, 2017 •

edited

Loading