This repository was archived by the owner on Sep 26, 2023. It is now read-only.
fix: fix dynamic flow control setting checks#1347
Merged
igorbernstein2 merged 2 commits intogoogleapis:masterfrom Apr 21, 2021
Merged
fix: fix dynamic flow control setting checks#1347igorbernstein2 merged 2 commits intogoogleapis:masterfrom
igorbernstein2 merged 2 commits intogoogleapis:masterfrom
Conversation
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
============================================
- Coverage 81.46% 81.43% -0.04%
+ Complexity 1347 1346 -1
============================================
Files 211 211
Lines 5730 5730
Branches 527 525 -2
============================================
- Hits 4668 4666 -2
- Misses 850 851 +1
- Partials 212 213 +1
Continue to review full report at Codecov.
|
igorbernstein2
suggested changes
Apr 19, 2021
vam-google
approved these changes
Apr 19, 2021
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM, but please address Igor's comments first.
igorbernstein2
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If LimitedExceededBehavior is Ignore, skip checking if all the elements or bytes limit are set.