This repository was archived by the owner on Sep 26, 2023. It is now read-only.
ci: linkage-monitor-artifacts.txt generation#1320
Merged
suztomo merged 2 commits intogoogleapis:masterfrom Mar 1, 2021
Merged
Conversation
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
============================================
- Coverage 79.69% 79.65% -0.04%
+ Complexity 1249 1248 -1
============================================
Files 209 209
Lines 5461 5461
Branches 464 464
============================================
- Hits 4352 4350 -2
- Misses 927 928 +1
- Partials 182 183 +1
Continue to review full report at Codecov.
|
elharo
approved these changes
Mar 1, 2021
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
I wonder if there's some way we could deduce this from the gradle files?
Member
Author
|
@elharo I wish there is. I didn't think of a better way to read values in build.gradle than coding within it in Groovy. |
Member
Author
|
It successfully detected linkage error in an example PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linkage Monitor by default searches for pom.xml files to get list of the artifacts that are generated by a repository. However certain repositories (such as gax-java) use Gradle and have no pom.xml files. Therefore Linkage Monitor has a functionality to let the repositories tell the list of artifacts. It reads linkage-monitor-artifacts.txt in the root of a repository.