Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

feat: add self signed jwt feature#1302

Closed
arithmetic1728 wants to merge 5 commits intomasterfrom
new_jwt_use_auth
Closed

feat: add self signed jwt feature#1302
arithmetic1728 wants to merge 5 commits intomasterfrom
new_jwt_use_auth

Conversation

@arithmetic1728
Copy link
Copy Markdown
Contributor

@arithmetic1728 arithmetic1728 commented Feb 16, 2021 •
edited
Loading

follow up PR of googleapis/google-auth-library-java#572

This PR does the following:
(1) added defaultScopes getter/setter to GoogleCredentialsProvider, and let GoogleCredentialsProvider passes the defaultScopes to ServiceAccountCredentials.
(2) updated google-auth-library-java version

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 16, 2021
@arithmetic1728 arithmetic1728 mentioned this pull request Feb 16, 2021
Closed
@arithmetic1728 arithmetic1728 force-pushed the new_jwt_use_auth branch 2 times, most recently from 5a99b2b to 551d917 Compare March 16, 2021 20:21
@arithmetic1728 arithmetic1728 changed the title feat: auth lib based self signed jwt feat: add self signed jwt feature Mar 16, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2021 •
edited
Loading

Codecov Report

Merging #1302 (5e3d4ce) into master (49efdc3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1302      +/-   ##
============================================
+ Coverage     80.34%   80.38%   +0.04%     
- Complexity     1331     1332       +1     
============================================
  Files           210      210              
  Lines          5682     5685       +3     
  Branches        519      519              
============================================
+ Hits           4565     4570       +5     
+ Misses          912      911       -1     
+ Partials        205      204       -1
Impacted Files Coverage Δ Complexity Δ
...google/api/gax/core/GoogleCredentialsProvider.java 87.50% <100.00%> (+1.29%) 6.00 <0.00> (ø)
.../java/com/google/api/gax/batching/BatcherImpl.java 96.06% <0.00%> (+1.12%) 23.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49efdc3...5e3d4ce. Read the comment docs.

@arithmetic1728 arithmetic1728 marked this pull request as ready for review March 17, 2021 00:10
@arithmetic1728 arithmetic1728 requested review from a team March 17, 2021 00:10
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2021
@arithmetic1728 arithmetic1728 removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2021
@arithmetic1728
Copy link
Copy Markdown
Contributor Author

arithmetic1728 commented Mar 17, 2021

@chingor13 I updated google-auth-library-java to 0.25.0 in dependencies.properties in this PR, but the ci / linkage-monitor test is using 0.24.1. How do I fix this?

Mar 17, 2021 12:29:47 AM com.google.cloud.tools.dependencies.linkagemonitor.LinkageMonitor run
INFO: BOM Coordinates: com.google.cloud:libraries-bom:19.0.0
Mar 17, 2021 12:34:26 AM com.google.cloud.tools.dependencies.linkagemonitor.LinkageMonitor run
SEVERE: Newly introduced problem:
(com.google.auth:google-auth-library-oauth2-http:0.24.1) com.google.auth.oauth2.GoogleCredentials's method createScoped(java.util.Collection, java.util.Collection) is not found
  referenced from com.google.api.gax.core.GoogleCredentialsProvider (com.google.api:gax:1.62.1-SNAPSHOT)

@suztomo suztomo mentioned this pull request Mar 17, 2021
Merged
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Mar 17, 2021

I need to release a new version of the libraries-bom to make the test pass, as Linkage Monitor uses the baseline from the latest release, not from the master branch.

@suztomo suztomo mentioned this pull request Mar 17, 2021
Merged
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Mar 18, 2021

I released com.google.cloud:libraries-bom:19.2.0. I just merged the master branch to trigger the Linkage Monitor check.

suztomo
suztomo previously requested changes Mar 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of the auth library breaks the java sample project. Can you check that first?

@arithmetic1728 arithmetic1728 requested a review from bshaffer March 19, 2021 05:44
@suztomo suztomo dismissed their stale review March 19, 2021 18:12

The fix of the libraries bom 19.2.1 was released

@chanseokoh chanseokoh deleted the new_jwt_use_auth branch October 29, 2021 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bshaffer bshaffer Awaiting requested review from bshaffer

1 more reviewer

@suztomo suztomo suztomo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arithmetic1728 @suztomo