Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

deps: update gRPC#1263

Merged
elharo merged 13 commits intomasterfrom
elharo-patch-2
Jan 29, 2021
Merged

deps: update gRPC#1263
elharo merged 13 commits intomasterfrom
elharo-patch-2

Conversation

@elharo
Copy link
Copy Markdown
Contributor

@elharo elharo commented Jan 14, 2021

@elharo elharo requested review from a team January 14, 2021 15:58
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 14, 2021
@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Jan 14, 2021 

Repository rule http_archive defined at:
  /home/runner/.cache/bazel/_bazel_runner/708235df2b9026c2ff59e4840c097026/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
ERROR: /home/runner/work/gax-java/gax-java/gax-grpc/BUILD.bazel:46:13: no such package '@io_netty_netty_tcnative_boringssl_static//jar': The repository '@io_netty_netty_tcnative_boringssl_static' could not be resolved and referenced by '//gax-grpc:gax_grpc'
ERROR: Analysis of target '//gax-grpc:gax_grpc' failed; build aborted: Analysis failed
INFO: Elapsed time: 12.565s
INFO: 0 processes.
ERROR: Couldn't start the build. Unable to run tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2021 •
edited
Loading

Codecov Report

Merging #1263 (1c96f64) into master (52296b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1263   +/-   ##
=========================================
  Coverage     79.19%   79.19%           
  Complexity     1235     1235           
=========================================
  Files           209      209           
  Lines          5378     5378           
  Branches        454      454           
=========================================
  Hits           4259     4259           
  Misses          939      939           
  Partials        180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52296b9...1c96f64. Read the comment docs.

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Jan 29, 2021

seems gRPC 1.35.0 still depends on commons-lang. Next release should remove that.

elharo
elharo commented Jan 29, 2021
View reviewed changes
Comment thread dependencies.properties
maven.io_opencensus_opencensus_api=io.opencensus:opencensus-api:0.24.0
maven.io_opencensus_opencensus_contrib_grpc_metrics=io.opencensus:opencensus-contrib-grpc-metrics:0.24.0
maven.io_opencensus_opencensus_contrib_http_util=io.opencensus:opencensus-contrib-http-util:0.24.0
maven.io_netty_netty_tcnative_boringssl_static=io.netty:netty-tcnative-boringssl-static:2.0.36.Final
Copy link
Copy Markdown
Contributor Author

@elharo elharo Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can anyone explain why this upgrade requires me to add all these transitive dependencies from gRPC? Something about bazel builds I'm missing? @ejona86

Copy link
Copy Markdown

@ejona86 ejona86 Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you aren't using mvn_install: https://github.com/googleapis/gax-java/blob/master/WORKSPACE

https://github.com/grpc/grpc-java/releases/tag/v1.33.0

bazel: Remove Maven repositories from repositories.bzl, in favor of maven_install. v1.27.0 introduced support for maven_install and encouraged users to migrate. See examples/WORKSPACE for an example. maven_install dramatically reduces the boilerplate for maven dependencies and properly handles transitive dependencies and version selection. gRPC is not yet using the @maven workspace, so it is still possible to use other dependency tools.

https://github.com/grpc/grpc-java/releases/tag/v1.27.0

Bazel users should migrate to maven_install. Please open an issue to report problems migrating to maven_install.

bazel: Support maven_install (#6553). See examples/WORKSPACE for typical usage. grpc-java still supports the jvm_maven_import_external()-based loading only to ease migration. grpc-java will drop usages of jvm_maven_import_external() in the future

@elharo elharo merged commit 95a7dab into master Jan 29, 2021
@elharo elharo deleted the elharo-patch-2 branch January 29, 2021 15:08
@elharo elharo mentioned this pull request Jan 30, 2021
Closed
@elharo elharo mentioned this pull request Feb 17, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@ejona86 ejona86 ejona86 left review comments

@miraleung miraleung miraleung approved these changes

@eaball35 eaball35 eaball35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elharo @ejona86 @miraleung @eaball35