Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

test(deps): update Mockito to 2.28.2#1257

Merged
elharo merged 9 commits intomasterfrom
elharo-patch-3
Jan 28, 2021
Merged

test(deps): update Mockito to 2.28.2#1257
elharo merged 9 commits intomasterfrom
elharo-patch-3

Conversation

@elharo
Copy link
Copy Markdown
Contributor

@elharo elharo commented Dec 8, 2020

No description provided.

@elharo elharo requested review from a team December 8, 2020 17:23
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2020

Codecov Report

Merging #1257 (628f676) into master (a21f57b) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1257      +/-   ##
============================================
+ Coverage     79.19%   79.23%   +0.03%     
- Complexity     1235     1236       +1     
============================================
  Files           209      209              
  Lines          5378     5378              
  Branches        454      454              
============================================
+ Hits           4259     4261       +2     
+ Misses          939      938       -1     
+ Partials        180      179       -1     
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/api/gax/batching/BatcherImpl.java 98.06% <0.00%> (+1.29%) 17.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21f57b...628f676. Read the comment docs.

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Dec 8, 2020

Weird. Why does Bazel alone fail?

Executed 104 out of 104 tests: 50 tests pass and 54 fail locally.
Error: Process completed with exit code 3.

Copy link
Copy Markdown
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add the version number to the PR title so it's easier to see without looking at the delta?

@elharo elharo changed the title deps: update Mockito deps: update Mockito to 2.28.2 Dec 9, 2020
@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Jan 12, 2021

autovalue issues might be the root cause of Bazel's failures:

INFO: From Building gax/libgax_testlib.jar (91 source files) and running annotation processors (AutoValueProcessor):
warning: -parameters is not supported for target value 1.7. Use 1.8 or later.
warning: An exception occurred while looking for AutoValue extensions. No extensions will function. This may be due to a corrupt jar file in the compiler's classpath. Exception: java.util.ServiceConfigurationError: com.google.auto.value.extension.AutoValueExtension: Provider com.google.auto.value.extension.memoized.MemoizeExtension could not be instantiated
INFO: From Building gax/libgax-class.jar (185 source files) and running annotation processors (AutoValueProcessor):
warning: -parameters is not supported for target value 1.7. Use 1.8 or later.
warning: An exception occurred while looking for AutoValue extensions. No extensions will function. This may be due to a corrupt jar file in the compiler's classpath. Exception: java.util.ServiceConfigurationError: com.google.auto.value.extension.AutoValueExtension: Provider com.google.auto.value.extension.memoized.MemoizeExtension could not be instantiated

@chingor13 chingor13 changed the title deps: update Mockito to 2.28.2 test(deps): update Mockito to 2.28.2 Jan 14, 2021
@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Jan 28, 2021

Weirdly this only happens with Bazel:

Time: 1.023
There were 2 failures:
1) serviceAccountReplacedWithJwtTokens(com.google.api.gax.core.GoogleCredentialsProviderTest)
org.mockito.exceptions.base.MockitoException: 
Mockito cannot mock this class: interface java.security.PrivateKey.

Mockito can only mock non-private & non-final classes.
If you're not sure why you're getting this error, please report to the mailing list.

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Jan 28, 2021

Googling suggest we need an explicit dependency on ByteBuddy 1.9.7:

@elharo elharo merged commit 78940f5 into master Jan 28, 2021
@elharo elharo deleted the elharo-patch-3 branch January 28, 2021 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants